Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enumerable#first block arities #3556

Closed

Conversation

@kachick
Copy link
Member

@kachick kachick commented Jan 8, 2016

I guess this fixes #3554

@ioquatix
Copy link

@ioquatix ioquatix commented Jan 9, 2016

Awesome, thanks so much. I guess we should try to evaluate #cycle or any other similar methods (#count?)

Loading

@YorickPeterse
Copy link
Member

@YorickPeterse YorickPeterse commented Jan 9, 2016

Rebased into 87ef383...86bf317, thanks!

I guess we should try to evaluate #cycle or any other similar methods (#count?)

Yes, but those should go into a separate PR.

Loading

@ioquatix
Copy link

@ioquatix ioquatix commented Jan 9, 2016

Sure they would be a separate PR, but the Issue which is now closed also raised those points. Should I create a new issue?

Loading

@YorickPeterse
Copy link
Member

@YorickPeterse YorickPeterse commented Jan 9, 2016

@ioquatix If other methods suffer from the same problem then yes, an issue would be appreciated.

Loading

@kachick kachick deleted the fix-enumerable-first-block-arity branch Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants