Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in slice_(after|before) when iterator method yields more than one value #3584

Merged
merged 4 commits into from Jan 28, 2016

Conversation

@jsyeo
Copy link
Member

@jsyeo jsyeo commented Jan 22, 2016

So I took some time to look at the issue that was reported by @ioquatix in #3554 (comment) and I found out that it affects all our slice_* methods. Unfortunately, I didn't spend much time to figure out how to fix this but I will come back to this when I have the time. As for this PR, I hope someone can give me some feedback with regard to the clarity of the description of the specs and the readability of the specs. I am not sure if the spec is readable enough in this current state.

@@ -46,6 +46,15 @@
end
end

describe "when iterator method yields more than one value" do
Copy link
Member

@YorickPeterse YorickPeterse Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"when an iterator method" reads more pleasant.

Loading

@YorickPeterse YorickPeterse self-assigned this Jan 22, 2016
@jsyeo jsyeo changed the title Add failing specs for slice_* when iterator method is changed Fix issue in slice_(after|before) when iterator method yields more than one value Jan 28, 2016
jsyeo added a commit that referenced this issue Jan 28, 2016
Fix issue in slice_(after|before) when iterator method yields more than one value
@jsyeo jsyeo merged commit 70ed311 into rubinius:master Jan 28, 2016
1 check passed
Loading
@jsyeo jsyeo deleted the jsyeo-slice-failing-specs branch Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants