Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ARGF.read_nonblock #3595

Closed
wants to merge 4 commits into from
Closed

Added ARGF.read_nonblock #3595

wants to merge 4 commits into from

Conversation

@YorickPeterse
Copy link
Member

@YorickPeterse YorickPeterse commented Jan 29, 2016

@ahmadsherif could you check if any specs from your Gist (https://gist.github.com/ahmadsherif/998858e65899716edd7d) and add them to this merge request if they're useful enough? I noticed you also moved a bunch of things around, I didn't include those because they don't seem to be related to read_nonblock itself.

@ahmadsherif
Copy link
Member

@ahmadsherif ahmadsherif commented Jan 29, 2016

@YorickPeterse I don't see more specs to add from the gist :). The stuff that was moved was a common behavior between readpartial and read_nonblock.

Loading

@YorickPeterse YorickPeterse deleted the argf-read-nonblock branch Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants