subscriptions#unsubscribe should be shown as a member route. #8

Merged
merged 1 commit into from Oct 21, 2011

Conversation

Projects
None yet
2 participants
@jclem
Contributor

jclem commented Oct 21, 2011

To avoid confusion, subscriptions#unsubscribe should be a member route, not a collection route here, i.e.

# bad
get 'subscriptions/:id/unsubscribe'
resources :subscriptions

instead of:

# bad
get 'subscriptions/unsubscribe' # this would be a collection route
resources :subscriptions

bbatsov added a commit that referenced this pull request Oct 21, 2011

Merge pull request #8 from jclem/master
subscriptions#unsubscribe should be shown as a member route.

@bbatsov bbatsov merged commit 86a35a9 into rubocop-hq:master Oct 21, 2011

@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Oct 21, 2011

Collaborator

Thanks!

Collaborator

bbatsov commented Oct 21, 2011

Thanks!

marocchino pushed a commit to marocchino/rails-style-guide that referenced this pull request May 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment