Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop-ast-0.4.0 has broken Layout/LineLength #113

Closed
jonnynux opened this issue Sep 14, 2020 · 4 comments
Closed

rubocop-ast-0.4.0 has broken Layout/LineLength #113

jonnynux opened this issue Sep 14, 2020 · 4 comments
Assignees

Comments

@jonnynux
Copy link

@jonnynux jonnynux commented Sep 14, 2020

With the latest version of the gem I receive the following error when executing rubocop:
An error occurred while Layout/LineLength cop was inspecting /home/jonny/Programming/myapp/app/workers/bot.rb:330:8.

@peterberkenbosch
Copy link

@peterberkenbosch peterberkenbosch commented Sep 14, 2020

confirming! Also see rubocop-hq/rubocop#8713

@peterberkenbosch
Copy link

@peterberkenbosch peterberkenbosch commented Sep 14, 2020

@jonnynux I had to update rubocop to 0.90.0. That fixes this problem.

@jonnynux
Copy link
Author

@jonnynux jonnynux commented Sep 14, 2020

Yes, it works great.

@marcandre
Copy link
Contributor

@marcandre marcandre commented Sep 14, 2020

Sorry for this. Yes, 0.4.0 is fully compatible with 0.89.0+ only.

Let's keep this issue open, I should introduce a way for the main gem to know this and at least warn...

@marcandre marcandre self-assigned this Sep 14, 2020
DanielRussell added a commit to tedconf/code-style-guides that referenced this issue Sep 21, 2020
As of 2020-09-21, we're pinned to `rubocop` 0.86.0.  That version
picks up `rubocop-ast` 0.4.2, which throws errors on `Layout/LineLength`.

Upgrading rubocop to 0.90 or above seems to fix things.

rubocop-hq/rubocop-ast#113

rubocop-hq/rubocop#8713
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Sep 24, 2020
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Sep 24, 2020
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Sep 24, 2020
marcandre added a commit to marcandre/rubocop-ast that referenced this issue Sep 24, 2020
@marcandre marcandre closed this in aef761b Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.