Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Rails/SaveBang as unsafe autocorrect #101

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@prathamesh-sonpatki
Copy link
Contributor

commented Aug 7, 2019

We faced an issue where our custom update method call was changed to update! but the method name remained same in the method definition.

def update
end

update!
def update
end

update

So the cop is not safe for auto correct.

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:rails-bang-unsafe branch from ddd932f to 40580d9 Aug 7, 2019

CHANGELOG.md Outdated Show resolved Hide resolved
Mark Rails/SaveBang as unsafe autocorrect
We faced an issue where our custom `update` method call was changed to `update!` but the method name remained same in the method definition.

```ruby
def update
end

update!
```

```ruby
def update
end

update
```

So the cop is not safe for auto correct.

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:rails-bang-unsafe branch from 40580d9 to eca224b Aug 7, 2019

@koic koic merged commit 965cd51 into rubocop-hq:master Aug 8, 2019

6 checks passed

ci/circleci: JRuby 9.2 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.3 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.4 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.5 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.6 Your tests passed on CircleCI!
Details
ci/circleci: Ruby HEAD Your tests passed on CircleCI!
Details

@prathamesh-sonpatki prathamesh-sonpatki deleted the prathamesh-sonpatki:rails-bang-unsafe branch Aug 8, 2019

@touhouota touhouota referenced this pull request Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.