Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ActiveRecord/Aliases as unsafe autocorrect #98

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@prathamesh-sonpatki
Copy link
Contributor

commented Jul 30, 2019

We faced an issue where our custom update_attributes method call was changed to update but the method name remained same in the method definition.

Original code

def update_attributes
end

update_attributes

After running rubocop --safe-auto-correct:

def update_attributes
end

update

So the cop is not safe for auto correct.

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:patch-1 branch from 2d355b0 to 04e8000 Jul 30, 2019

config/default.yml Outdated Show resolved Hide resolved
@koic

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Could you add a changelog entry? I think the following is an example.
rubocop-hq/rubocop#6613

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:patch-1 branch from 04e8000 to d1b5fcf Jul 30, 2019

@prathamesh-sonpatki prathamesh-sonpatki changed the title Make ActiveRecordAliases scope false Mark ActiveRecordAliases as unsafe autocorrect Jul 30, 2019

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:patch-1 branch from d1b5fcf to 7d350e5 Jul 30, 2019

@prathamesh-sonpatki prathamesh-sonpatki changed the title Mark ActiveRecordAliases as unsafe autocorrect Mark ActiveRecord/Aliases as unsafe autocorrect Jul 30, 2019

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:patch-1 branch 2 times, most recently from 83b0622 to b15ae49 Jul 30, 2019

@prathamesh-sonpatki

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@koic Thanks, done!

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:patch-1 branch from b15ae49 to 03525c1 Jul 30, 2019

config/default.yml Outdated Show resolved Hide resolved

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:patch-1 branch from 03525c1 to 7c55d9b Jul 30, 2019

@koic
koic approved these changes Jul 30, 2019
Copy link
Member

left a comment

This looks good. Thanks for your quick response!

CHANGELOG.md Outdated Show resolved Hide resolved
Mark ActiveRecord/Aliases as unsafe autocorrect
We faced an issue where our custom `update_attributes` method call was changed to `update` but the method name remained same in the method definition.

```ruby
def update_attributes
end

update_attributes
```

```ruby
def update_attributes
end

update
```

So the cop is not safe for auto correct.

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:patch-1 branch from 7c55d9b to 038af92 Jul 30, 2019

@koic koic merged commit 20de97e into rubocop-hq:master Aug 1, 2019

6 checks passed

ci/circleci: JRuby 9.2 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.3 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.4 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.5 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.6 Your tests passed on CircleCI!
Details
ci/circleci: Ruby HEAD Your tests passed on CircleCI!
Details
@touhouota touhouota referenced this pull request Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.