Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `RSpec/SubjectStub` cop matches receive message inside all matcher #497

Merged
merged 1 commit into from Nov 9, 2017

Conversation

@bquorning
Copy link
Member

commented Nov 9, 2017

Rebased version of #491.

Fixes #488.
Closes #491.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes.
  • The build (bundle exec rake) is passing.

@bquorning bquorning requested a review from Darhazer Nov 9, 2017

@bquorning

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2017

Could you give me a quick +1 here, @Darhazer ?

@bquorning bquorning merged commit 1d9baa8 into master Nov 9, 2017

14 checks passed

buildkite/rubocop-rspec Build #909 passed (2 minutes, 54 seconds)
Details
buildkite/rubocop-rspec/pipeline Passed (2 seconds)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-1 Passed (57 seconds)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-2 Passed (1 minute, 45 seconds)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-3 Passed (1 minute, 42 seconds)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-4 Passed (1 minute, 46 seconds)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-1 Passed (1 minute, 49 seconds)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-2 Passed (15 seconds)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-3 Passed (15 seconds)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-4 Passed (14 seconds)
Details
buildkite/rubocop-rspec/scroll-configuration Passed (8 seconds)
Details
buildkite/rubocop-rspec/verify-build-unchanged Passed (57 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bquorning bquorning deleted the walf443-subject_stub_ignore_all_matcher branch Nov 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.