New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Circle CI instead of Travis #528

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
4 participants
@bquorning
Member

bquorning commented Jan 8, 2018

For a while now I’ve been wanting to switch from Travis CI to Circle CI. In my experience, Circle is much, much faster than Travis, and seeing how we suddenly get weird errors when trying out a new Ruby (#526), I’m leaning even more towards Circle.

There are a few TODOs though:

  • Set up Circle CI (https://circleci.com/signup/ -> Sign up with GitHub -> Public Repos Only) for backus/rubocop-rspec
  • Remove Travis config
  • Disconnect Travis?
  • Change Travis “status image” in the Readme to a Circle equivalent.
  • Fix codeclimate integration.

The last 4 items, we’ll do later.

@bquorning bquorning requested review from Darhazer, backus and dgollahon Jan 8, 2018

@backus

This comment has been minimized.

Collaborator

backus commented Jan 10, 2018

High level, I'm all for dropping Travis for Circle. When I setup the buildkite I thought they would have public build pages by now but I guess they're still working on that. I just clicked through the repo setup for circle for this project so you should be able to edit the config and whatnot now

@backus backus closed this Jan 10, 2018

@backus backus reopened this Jan 10, 2018

@backus

This comment has been minimized.

Collaborator

backus commented Jan 10, 2018

Looks great! I played with the new circle CI config a bit recently for a private project and I really like their new setup. It seems like a more managed version of what I tried to setup for BK.

@backus

backus approved these changes Jan 10, 2018

@bquorning bquorning closed this Jan 10, 2018

@bquorning bquorning reopened this Jan 10, 2018

@bquorning bquorning force-pushed the bquorning:circle-ci branch 2 times, most recently from 029e9eb to 7e230a5 Jan 10, 2018

@bquorning

This comment has been minimized.

Member

bquorning commented Jan 10, 2018

It seems like a more managed version of what I tried to setup for BK.

Does that mean I should aim for replacing BuildKite as well?

Should this PR include removal of Travis (and Buildkite) configuration – or should I do that in a follow-up PR?

I guess both services would also need to be “detached” from this repository in order to not continue testing all PRs, right?

@bquorning bquorning force-pushed the bquorning:circle-ci branch from 7e230a5 to 5fe79bd Jan 10, 2018

@bquorning

This comment has been minimized.

Member

bquorning commented Jan 10, 2018

So… I’m reducing the scope of this PR to:

  • Set up Circle CI.

In other pull requests we’ll discuss:

  • Integrate CircleCI with CodeClimate.
  • Disconnect Travis and remove config, and fix CI status image in Readme.
  • Disconnect BuildKite and remove config.

which means this PR is done.

@Tr4pSt3R

This comment has been minimized.

Tr4pSt3R commented Jan 11, 2018

@bquorning are these PRs ready or should they be added as issues and labelled as improvements so that they are, somehow, accountable?
Re:

In other pull requests we’ll discuss:

Integrate CircleCI with CodeClimate.
Disconnect Travis and remove config, and fix CI status image in Readme.
Disconnect BuildKite and remove config.
@bquorning

This comment has been minimized.

Member

bquorning commented Jan 11, 2018

@Tr4pSt3R I’ll probably just open those PRs one by one after merging this one.

@bquorning bquorning merged commit 0a42af9 into rubocop-hq:master Jan 11, 2018

20 checks passed

buildkite/rubocop-rspec Build #1018 passed (3 minutes, 10 seconds)
Details
buildkite/rubocop-rspec/pipeline Passed (1 second)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-1 Passed (1 minute, 3 seconds)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-2 Passed (1 minute, 52 seconds)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-3 Passed (2 minutes)
Details
buildkite/rubocop-rspec/rspec-rspec-2-dot-4 Passed (1 minute, 52 seconds)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-1 Passed (2 minutes)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-2 Passed (16 seconds)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-3 Passed (15 seconds)
Details
buildkite/rubocop-rspec/rubocop-rubocop-2-dot-4 Passed (14 seconds)
Details
buildkite/rubocop-rspec/scroll-configuration Passed (9 seconds)
Details
buildkite/rubocop-rspec/verify-build-unchanged Passed (1 minute)
Details
ci/circleci: jruby Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.1 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.2 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5 Your tests passed on CircleCI!
Details
ci/circleci: ruby-latest Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bquorning bquorning deleted the bquorning:circle-ci branch Jan 13, 2018

@bquorning bquorning referenced this pull request Jan 13, 2018

Merged

Remove other CI configurations #534

9 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment