Improve RSpec/SubjectStub cop #770
Remove special case `all` matcher from SubjectStub
This special case treatment was added to address one use case, of an object that acts as a container for and a delegator of method calls to containing items by inheriting from an `Array`. The original code that suffered from a false detection was: expect(formatter_set).to all(receive(:started).with(files)) formatter_set.started(files) However, it has been [reworked to](https://github.com/rubocop-hq/rubocop/blob/a0aaa233c20e18784d841212e1caa724bcc919f7/spec/rubocop/formatter/formatter_set_spec.rb#18): expect(formatter_set).to receive(:started).with(files) expect(formatter_set).to receive(:started).with(files) formatter_set.started(files) and all known cases for this specific offence case are gone.
- Loading branch information...
ProTip! Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.