Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.43.0 #998

Merged
merged 1 commit into from Aug 17, 2020
Merged

Bump version to v1.43.0 #998

merged 1 commit into from Aug 17, 2020

Conversation

@bquorning
Copy link
Member

@bquorning bquorning commented Aug 16, 2020

We have a lot of great changes just sitting on the master branch waiting for a release. And 4 new contributors!

Not to diminish any of the contributions, but the reason I want to create a release now (and I should have done it weeks ago) is that it will be explicitly incompatible with RuboCop 1.0. I hope that as many as possible of our users will upgrade to 1.43.0, so that the will be (temporarily) blocked from upgrading when RuboCop 1.0 is released.

Please note that I am adding VersionAdded: '1.43' for RSpec/MultipleMemoizedHelpers which seemed to be missing.

Also I think our documentation isn’t being updated correctly at the moment, and we should fix that ASAP. But again, I wanted to get this release out ASAP too :-)


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).
@bquorning bquorning requested review from pirj and Darhazer Aug 16, 2020
@pirj
pirj approved these changes Aug 16, 2020
Copy link
Member

@pirj pirj left a comment

That was a very productive month!

@bquorning bquorning merged commit 3d4f211 into master Aug 17, 2020
13 checks passed
13 checks passed
ci/circleci: code-climate Your tests passed on CircleCI!
Details
ci/circleci: confirm_config_and_documentation Your tests passed on CircleCI!
Details
ci/circleci: edge-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby Your tests passed on CircleCI!
Details
ci/circleci: rspec-2.4 Your tests passed on CircleCI!
Details
ci/circleci: rspec-2.5 Your tests passed on CircleCI!
Details
ci/circleci: rspec-2.6 Your tests passed on CircleCI!
Details
ci/circleci: rspec-2.7 Your tests passed on CircleCI!
Details
ci/circleci: rubocop-2.4 Your tests passed on CircleCI!
Details
ci/circleci: rubocop-2.5 Your tests passed on CircleCI!
Details
ci/circleci: rubocop-2.6 Your tests passed on CircleCI!
Details
ci/circleci: rubocop-2.7 Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@bquorning bquorning deleted the release branch Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.