New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No offense detected on a block that looks wrong #1309

Closed
kathgironpe opened this Issue Aug 28, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@kathgironpe

kathgironpe commented Aug 28, 2014

There should be an offense detected here but there it says "no offenses detected."

    devise_parameter_sanitizer.for(:account_update) do
      |u| u.permit(:username, :email, :password, :password_confirmation, :current_password)
    end
@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Aug 28, 2014

Collaborator

Yep, we'll have to enhance MultilineBlockLayout to discover such problems.

Collaborator

bbatsov commented Aug 28, 2014

Yep, we'll have to enhance MultilineBlockLayout to discover such problems.

@kathgironpe

This comment has been minimized.

Show comment
Hide comment
@kathgironpe

kathgironpe Aug 28, 2014

@bbatsov great! Thank you!

kathgironpe commented Aug 28, 2014

@bbatsov great! Thank you!

lumeet added a commit to lumeet/rubocop that referenced this issue Jan 20, 2015

Add argument handling to MultilineBlockLayout
The cop now registers an offense for arguments on a wrong line.
Auto-correction is also applied to these expressions.

Fixes rubocop-hq#1309

lumeet added a commit to lumeet/rubocop that referenced this issue Jan 20, 2015

Add argument handling to MultilineBlockLayout
The cop now registers an offense for arguments on a wrong line.
Auto-correction is also applied to these expressions.

Fixes rubocop-hq#1309.

lumeet added a commit to lumeet/rubocop that referenced this issue Jan 21, 2015

[Fix rubocop-hq#1309] Add argument handling to MultilineBlockLayout
The cop now registers an offense for arguments on a wrong line.
Auto-correction is also applied to these expressions.

bbatsov added a commit that referenced this issue Jan 21, 2015

Merge pull request #1585 from lumeet/1309/improve_multiline_block_layout
[Fix #1309] Add argument handling to MultilineBlockLayout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment