New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rubocop to check rails 5 test http method usage #3370

Closed
logicminds opened this Issue Aug 4, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@logicminds
Contributor

logicminds commented Aug 4, 2016

rails 5 deprecates the usage of http method calls in test code and prefers the usage of keyword arguments instead

logicminds added a commit to nwops/rubocop that referenced this issue Aug 5, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the process method for test classes.  In addition, rails 5
     deprecates the usage of http method calls from test classes
     as its confusing.  Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env, xhr

     This commit adds a new Rails/ProcessMethod cop that detects
     and fixes those deprecated methods in tests.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 5, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 5, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 5, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 5, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 5, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 18, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 22, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 22, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/KeyWordArgs cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Aug 22, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/HttpPositionalArguments cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Sep 7, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/HttpPositionalArguments cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Oct 6, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/HttpPositionalArguments cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Oct 6, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/HttpPositionalArguments cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Oct 6, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/HttpPositionalArguments cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

logicminds added a commit to nwops/rubocop that referenced this issue Oct 7, 2016

Adds ability to inspect rails 5 test process method (rubocop-hq#3370)
   * rails 5 introduces the ability to pass keyword arguments
     to the http method calls for test classes.
     Any rails 5 upgrade would likely see
     hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

     This commit adds a new Rails/HttpPositionalArguments cop that detects
     and fixes those deprecated methods in tests by replacing
     with keyword args like params and headers.

bbatsov added a commit that referenced this issue Oct 7, 2016

Add the ability to inspect Rails 5 test process method (#3370) (#3365)
Rails 5 introduces the ability to pass keyword arguments
to the http method calls for test classes.
Any Rails 5 upgrade would likely see
hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

This commit adds a new Rails/HttpPositionalArguments cop that detects
 and fixes those deprecated methods in tests by replacing
 with keyword args like params and headers.

Neodelf added a commit to Neodelf/rubocop that referenced this issue Oct 15, 2016

Add the ability to inspect Rails 5 test process method (rubocop-hq#3370
…) (rubocop-hq#3365)

Rails 5 introduces the ability to pass keyword arguments
to the http method calls for test classes.
Any Rails 5 upgrade would likely see
hundreds if not thousands of messages like:

     DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
     methods will accept
     only the following keyword arguments in future Rails versions:
     params, headers, env.

This commit adds a new Rails/HttpPositionalArguments cop that detects
 and fixes those deprecated methods in tests by replacing
 with keyword args like params and headers.

@logicminds logicminds closed this Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment