New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement options to run only safe cops and safe auto-corrects #5980

Closed
bbatsov opened this Issue Jun 9, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@bbatsov
Collaborator

bbatsov commented Jun 9, 2018

That's a continuation of #5978. Once we know which cops are safe it'd be trivial do the following:

  • add a command line switch --safe to run only safe cops
  • add a command line switch --safe-auto-correct to run only safe auto-corrections
  • Add some config options to enable safe cops/safe auto-corrections through .rubocop.yml

@bbatsov bbatsov added the enhancement label Jun 9, 2018

@bbatsov bbatsov added this to the 1.0.0 milestone Jun 9, 2018

@perlun

This comment has been minimized.

perlun commented Jun 13, 2018

Good idea. I would even go as far as to say that --safe and --safe-auto-correct should be the default, so that potentially "unsafe" cops & auto-corrections are disabled by default. Less noise from people running them by mistake; people who really want these cops are usually clever enough to figure out how to enable them anyway. 😉

@bbatsov

This comment has been minimized.

Collaborator

bbatsov commented Aug 14, 2018

Perhaps. On the other hand that'd be a departure from the current behaviour and it would certainly surprise a few people. Let's implement the metadata and the options firsts, changing the defaults is easy afterwards. 😄

@bbatsov

This comment has been minimized.

Collaborator

bbatsov commented Sep 27, 2018

@Darhazer I guess it makes sense for you to reap the benefits of your work on the huge metadata tasks, so I'm assigning this to you.

Darhazer added a commit that referenced this issue Sep 28, 2018

Darhazer added a commit that referenced this issue Sep 28, 2018

Darhazer added a commit that referenced this issue Sep 28, 2018

Darhazer added a commit that referenced this issue Sep 28, 2018

Darhazer added a commit that referenced this issue Sep 28, 2018

@bbatsov bbatsov closed this in 806f95f Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment