Add auto-correct to rescue modifier #2126
Conversation
rrosenblum
force-pushed
the
autocorrect_rescue_modifier
branch
from
d9f6765
to
d3f5d31
Compare
| @@ -10,6 +10,14 @@ def configured_indentation_width | |||
| config.for_cop('IndentationWidth')['Width'] | |||
| end | |||
|
|
|||
| def indentation(node) | |||
| offset(node) + (' ' * configured_indentation_width) | |||
There was a problem hiding this comment.
I'm guessing where allocating this a lot. He should probably make it a frozen constant.
I have extracted the I am working on another commit that will extract commonly used variables to constants. I have been using memory_profiler to identify areas that can be cleaned up. So far, I have reduced memory allocation by RuboCop by about 8%. |
rrosenblum
force-pushed
the
autocorrect_rescue_modifier
branch
from
d3f5d31
to
bf406a7
Compare
Add auto-correct to rescue modifier
Excellent! We should probably spend some time in the future on performance optimizations as well. People with huge projects often complain that running RuboCop takes quite a while. |
|
I am all for making RuboCop more performant. #2047 address auto-correct, but it does not address over all performance. |
No description provided.