New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3167] Added VariableNumber Cop #3416

Merged
merged 1 commit into from Aug 20, 2016

Conversation

Projects
None yet
3 participants
@sooyang
Contributor

sooyang commented Aug 14, 2016

This cop makes sure that all numbered variables use the configured style, snake_case, normalcase or non_integer, for their numbering as suggested in issue #3167
The default style for variable numbering is set to normalcase.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Aug 16, 2016

Collaborator

This has to be rebased.

Collaborator

bbatsov commented Aug 16, 2016

This has to be rebased.

@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Aug 16, 2016

Collaborator

I'd rather us use normalcase by default. It's the most common in the codebase anyways.

Collaborator

bbatsov commented Aug 16, 2016

I'd rather us use normalcase by default. It's the most common in the codebase anyways.

@bbatsov bbatsov merged commit af0bc67 into rubocop-hq:master Aug 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lucascaton

This comment has been minimized.

Show comment
Hide comment
@lucascaton

lucascaton Sep 26, 2016

@bbatsov @sooyang, shouldn't category_i18n be an exception?

lucascaton commented Sep 26, 2016

@bbatsov @sooyang, shouldn't category_i18n be an exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment