New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto-Correct for `Bundler/OrderedGems` cop #3757

Merged
merged 1 commit into from Dec 1, 2016

Conversation

Projects
None yet
2 participants
@pocke
Member

pocke commented Dec 1, 2016

Ref #3657 #3600

Goal

Auto Correct not sorted gems.

e.g.

gem 'b'
gem 'd'
gem 'c'
gem 'a'

gem 'a'
gem 'b'
gem 'c'
gem 'd'

Note

I added autocorrect_source_with_loop test helper method to execute auto-correction with loop.
This method is based on do_inspection_loop.
https://github.com/bbatsov/rubocop/blob/ed4aeb845bfcaaff0648d365c5b46a2e725347f7/lib/rubocop/runner.rb#L179-L202


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).
Add Auto-Correct for `Bundler/OrderedGems` cop
See also #3657 #3600

Goal
----

Auto Correct not sorted gems.

e.g.

```ruby
gem 'b'
gem 'd'
gem 'c'
gem 'a'

gem 'a'
gem 'b'
gem 'c'
gem 'd'
```

Note
-----

I added `autocorrect_source_with_loop` test helper method to execute auto-correction with loop.
This method is based on do_inspection_loop.
https://github.com/bbatsov/rubocop/blob/ed4aeb845bfcaaff0648d365c5b46a2e725347f7/lib/rubocop/runner.rb#L179-L202

@bbatsov bbatsov merged commit df0e1aa into rubocop-hq:master Dec 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Dec 1, 2016

Collaborator

👍 Good work!

Collaborator

bbatsov commented Dec 1, 2016

👍 Good work!

@pocke pocke deleted the pocke:auto-correct-for-bundler/ordered_gems branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment