New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a space before first argument of a method call #4265

Merged
merged 4 commits into from Apr 12, 2017

Conversation

Projects
None yet
4 participants
@cjlarose
Contributor

cjlarose commented Apr 12, 2017

The Ruby parser appears to be completely fine with something like

puts'hello'

The cop Style/SpaceBeforeFirstArg claims to check that "exactly one space is used between a method name and the first argument for method calls without parentheses", but does not account for source code that has zero spaces between the method name and the first argument.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).
@rchasman

This comment has been minimized.

Show comment
Hide comment
@rchasman

rchasman commented Apr 12, 2017

🐬

@rchasman

This comment has been minimized.

Show comment
Hide comment
@rchasman

rchasman commented Apr 12, 2017

^ LGTM

Show outdated Hide outdated CHANGELOG.md
@Drenmi

This comment has been minimized.

Show comment
Hide comment
@Drenmi

Drenmi Apr 12, 2017

Collaborator

Great first contribution! ❤️

Collaborator

Drenmi commented Apr 12, 2017

Great first contribution! ❤️

@@ -4,6 +4,7 @@
### Bug fixes
* [#4265](https://github.com/bbatsov/rubocop/pull/4265): Require a space before first argument of a method call in `Style/SpaceBeforeFirstArg` cop. ([@cjlarose][])

This comment has been minimized.

@bbatsov

bbatsov Apr 12, 2017

Collaborator

You have to add yourself to the bottom of the changelog.

@bbatsov

bbatsov Apr 12, 2017

Collaborator

You have to add yourself to the bottom of the changelog.

This comment has been minimized.

@cjlarose

cjlarose Apr 12, 2017

Contributor

Sorry about that! Updated the CHANGELOG with a link to myself.

@cjlarose

cjlarose Apr 12, 2017

Contributor

Sorry about that! Updated the CHANGELOG with a link to myself.

cjlarose added some commits Apr 12, 2017

Require a space before first argument of a method call
Ruby permits a method name to be followed immediately by a string
literal, with no space between them. This change updates the
SpaceBeforeFirstArg cop to register a violation for source code that
does this.

@bbatsov bbatsov merged commit fde6b20 into rubocop-hq:master Apr 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Apr 12, 2017

Collaborator

👍

Collaborator

bbatsov commented Apr 12, 2017

👍

brandonweiss added a commit to brandonweiss/rubocop that referenced this pull request Jul 13, 2017

Require a space before first argument of a method call (#4265)
Ruby permits a method name to be followed immediately by a string
literal, with no space between them. This change updates the
SpaceBeforeFirstArg cop to register a violation for source code that
does this.

satyap added a commit to brandonweiss/rubocop that referenced this pull request Jan 11, 2018

Require a space before first argument of a method call (#4265)
Ruby permits a method name to be followed immediately by a string
literal, with no space between them. This change updates the
SpaceBeforeFirstArg cop to register a violation for source code that
does this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment