New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract and test RuboCop::Cop::Generator #4435

Merged
merged 1 commit into from May 28, 2017

Conversation

Projects
None yet
2 participants
@backus
Contributor

backus commented May 28, 2017

Extracted behavior from the new_cop task. This refactor is extracted
from #4424 where I want to increase the scope of what the generator
can produce.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).
Extract and test RuboCop::Cop::Generator
Extracted behavior from the new_cop task. This refactor is extracted
from #4424 where I want to increase the scope of what the generator
can produce.
@backus

This comment has been minimized.

Show comment
Hide comment
@backus

backus May 28, 2017

Contributor

cc @pocke

Contributor

backus commented May 28, 2017

cc @pocke

@bbatsov bbatsov merged commit fa618d7 into rubocop-hq:master May 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov May 28, 2017

Collaborator

Nicely done!

Collaborator

bbatsov commented May 28, 2017

Nicely done!

@backus backus deleted the backus:refactor/cop-generator branch May 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment