New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Naming/FileName` allows `+` #6285

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@yensaki
Contributor

yensaki commented Sep 12, 2018

This PR changes that Naming/FileName allows file names including +.
It is needed by file names of ActionPack Variants.
Action Pack Variants file name is including +, for example, some_file.xlsx+mobile.axlsx.
It is available on axlsx, and its format is a target of rubocop.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default. It executes all tests and RuboCop for itself, and generates the documentation.
@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Sep 12, 2018

Collaborator

The problem with this change is that it makes + allowed for all file names and it's really needed just for one. Not sure what's the best way to tackle this.

Collaborator

bbatsov commented Sep 12, 2018

The problem with this change is that it makes + allowed for all file names and it's really needed just for one. Not sure what's the best way to tackle this.

@yensaki

This comment has been minimized.

Show comment
Hide comment
@yensaki

yensaki Sep 12, 2018

Contributor

Should it only be allowed that + contains just once in a file name?
I think + is the same as ? and ! in SNAKE_CASE.

Contributor

yensaki commented Sep 12, 2018

Should it only be allowed that + contains just once in a file name?
I think + is the same as ? and ! in SNAKE_CASE.

@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Sep 13, 2018

Collaborator

I guess so. Btw, I wonder if we should do something else - split filename that have + in them and match both parts of the filename to the regexp.

Collaborator

bbatsov commented Sep 13, 2018

I guess so. Btw, I wonder if we should do something else - split filename that have + in them and match both parts of the filename to the regexp.

`Naming/FileName` allows `+`
This PR changes that `Naming/FileName` allows file names including `+`.
It is needed by file names of [ActionPack Variants](https://guides.rubyonrails.org/4_1_release_notes.html#action-pack-variants).
Action Pack Variants file name is including `+`, for example, 'some_file.xlsx+mobile.axlsx'.
It is available on `axlsx`, and its format is a target
of rubocop.
@yensaki

This comment has been minimized.

Show comment
Hide comment
@yensaki

yensaki Sep 13, 2018

Contributor

Sure. I did it.

Contributor

yensaki commented Sep 13, 2018

Sure. I did it.

@bbatsov bbatsov merged commit 860f7f8 into rubocop-hq:master Sep 13, 2018

23 checks passed

ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-rc-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-rc-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-rc-spec Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bbatsov

This comment has been minimized.

Show comment
Hide comment
@bbatsov

bbatsov Sep 13, 2018

Collaborator

Thanks!

Collaborator

bbatsov commented Sep 13, 2018

Thanks!

@yensaki yensaki deleted the yensaki:change_naming_file_name_to_allow_plus_word branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment