New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI setting using CircleCI 2.1 syntax #6579

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@sue445
Copy link
Contributor

sue445 commented Dec 14, 2018

CircleCI 2.1 is now available

https://circleci.com/changelog/#reusable-commands-and-executors-xcode-10-image-and-macos-plan-settings-updates

So I refactored .circleci/config.yml with 2.1 syntax

This works on my repo.
https://circleci.com/workflow-run/d2405bdd-0542-4c7b-a161-8e342e87fd7c

BTY if Enable build processing (preview) is disabled, please enable this 馃檹

2018-12-14 18 41 47


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@sue445 sue445 referenced this pull request Dec 14, 2018

Closed

Refactor CI setting using CircleCI 2.1 syntax #6578

4 of 8 tasks complete

@sue445 sue445 force-pushed the sue445:circleci_2.1_new branch from e945f8e to 6b4f44b Dec 14, 2018

@sue445 sue445 force-pushed the sue445:circleci_2.1_new branch from 6b4f44b to da4a252 Dec 14, 2018

@bquorning

This comment has been minimized.

Copy link
Member

bquorning commented Dec 17, 2018

I have been playing with the 2.1 syntax as well, ended up with this config file: https://github.com/bquorning/rubocop/blob/acaf4a0924b14fc30b6dfe60986f96d02703de62/.circleci/config.yml

Bear in mind that all we need to do to have 2.1 compatible syntax is changing version: 2 to version: 2.1. We don鈥檛 need to use any of the new features. 馃槃

@sue445

This comment has been minimized.

Copy link
Contributor

sue445 commented Dec 17, 2018

@bquorning

We don鈥檛 need to use any of the new features.

I see.

When use 2.1 syntax (e.g. Parameterized Jobs), .circleci/config.yml will be shorter. (in this case: 304 lines -> 278 lines)

@sue445 sue445 closed this Dec 17, 2018

@bquorning

This comment has been minimized.

Copy link
Member

bquorning commented Dec 17, 2018

Yeah, we can make the config a bit shorter. I鈥檓 trying to decide whether it makes the config more readable, or less. I鈥檒l have a closer look soon, I hope. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment