Rename enforced style for Layout/IndentationConsistency
#7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rubocop#7113 (comment). This PR renames enforced style for `Layout/IndentationConsistency` from `EnabledStyle: outdented_access_modifiers` to `EnabledStyle: indented_internal_methods`. Here is an example style that the name `indented_internal_methods` represents: ```ruby # good class Foo def bar end private def baz end end ```
8 tasks
|
👍 |
sue445
added a commit
to sue445/onkcop
that referenced
this pull request
Jun 25, 2019
`EnforcedStyle: rails` is renamed to `EnforcedStyle: indented_internal_methods` since rubocop v0.72.0 ``` $ bundle exec rubocop -P Error: obsolete `EnforcedStyle: rails` (for Layout/IndentationConsistency) found in vendor/bundle/ruby/2.6.0/bundler/gems/onkcop-6256494c1f86/config/rubocop.yml `EnforcedStyle: rails` has been renamed to `EnforcedStyle: indented_internal_methods` ``` c.f. rubocop/rubocop#7163
koic
added a commit
to koic/rails
that referenced
this pull request
Aug 15, 2019
### Summary RuboCop 0.74.0 has been released. https://github.com/rubocop-hq/rubocop/releases/tag/v0.74.0 And rubocop-0-74 channel is available in Code Climate. https://github.com/codeclimate/codeclimate/releases/tag/v0.85.5 This PR specifies the same RuboCop Performance (1.3.0) and RuboCop Rails (2.0.0) versions as Code Climate's Gemfile.lock. https://github.com/codeclimate/codeclimate-rubocop/blob/channel/rubocop-0-74/Gemfile.lock#L51-L55 Also, the `EnforcedStyle` of `Layout/IndentationConsistency` has been renamed from `EnforcedStyle: rails` to `EnforcedStyle: indented_internal_methods` - rubocop/rubocop#7113 - rubocop/rubocop#7163 And this commit disables `Layout/SpaceAroundOperators` that was changed from RuboCop 0.74 by rubocop/rubocop#7211. cf. rails#36943 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #7113 (comment).
This PR renames enforced style for
Layout/IndentationConsistencyfromEnabledStyle: outdented_access_modifierstoEnabledStyle: indented_internal_methods.Here is an example style that the name
indented_internal_methodsrepresents:Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.