Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Style/StringHashKeys as unsafe #7312

Conversation

@prathamesh-sonpatki
Copy link
Contributor

commented Aug 27, 2019

  • We noticed that this auto-correction by this cop can cause bugs
    where strings are explicitly expected as hash keys.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
@bbatsov

This comment has been minimized.

Copy link
Collaborator

commented Aug 28, 2019

Here the entire cop is unsafe, not just it's auto-correct.

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:mark-hash-string-keys-auto-correct-unsafe branch from 9b2e41a to 97625fa Aug 28, 2019

@prathamesh-sonpatki

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@bbatsov Yep I have updated the code to mark it as unsafe.

config/default.yml Show resolved Hide resolved
Mark Style/StringHashKeys as unsafe
- We noticed that this auto-correction by this cop can cause bugs
  where strings are explicitly expected as hash keys.

@prathamesh-sonpatki prathamesh-sonpatki force-pushed the prathamesh-sonpatki:mark-hash-string-keys-auto-correct-unsafe branch from 97625fa to d8d34f9 Aug 28, 2019

@prathamesh-sonpatki prathamesh-sonpatki changed the title Mark Style/StringHashKeys as unsafe autocorrect Mark Style/StringHashKeys as unsafe Aug 28, 2019

@koic koic merged commit dd5fc37 into rubocop-hq:master Aug 28, 2019

22 checks passed

ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.