Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConfigLoader.default_configuration for default #7632

Merged
merged 2 commits into from Apr 16, 2020

Conversation

@hanachin
Copy link
Contributor

hanachin commented Jan 6, 2020

When the config file path is same as the default config file,
use ConfigLoader.default_configuration instead of create a new config.

Because some plugins add their default config values to
ConfigLoader.default_configuration. So the Cops of the plugins expect
that default config values exists.

Fix rubocop-hq/rubocop-rails#127


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
@hanachin hanachin force-pushed the hanachin:fix_rubocop_rails_127 branch from ba3aac1 to 15103d4 Jan 7, 2020
When the config file path is same as the default config file,
use `ConfigLoader.default_configuration` instead of create a new config.

Because some plugins add their default config values to
`ConfigLoader.default_configuration`. So the Cops of the plugins expect
that default config values exists.

Fix rubocop-hq/rubocop-rails#127
@hanachin hanachin force-pushed the hanachin:fix_rubocop_rails_127 branch from 15103d4 to 0533089 Jan 7, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 21, 2020

@hanachin Sorry for the slow response! The changes look good, but you'll have to rebase on top of master.

@bbatsov bbatsov merged commit 532b681 into rubocop-hq:master Apr 16, 2020
1 of 21 checks passed
1 of 21 checks passed
ci/circleci: documentation-checks Your tests are queued behind your running builds
Details
ci/circleci: jruby-9.2-ascii_spec Your tests are queued behind your running builds
Details
ci/circleci: jruby-9.2-rubocop Your tests are queued behind your running builds
Details
ci/circleci: jruby-9.2-spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.4-ascii_spec CircleCI is running your tests
Details
ci/circleci: ruby-2.4-rubocop CircleCI is running your tests
Details
ci/circleci: ruby-2.4-spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.5-ascii_spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.5-rubocop Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.5-spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.6-ascii_spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.6-rubocop Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.6-spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.7-ascii_spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-2.7-rubocop CircleCI is running your tests
Details
ci/circleci: ruby-2.7-spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-head-ascii_spec Your tests are queued behind your running builds
Details
ci/circleci: ruby-head-rubocop CircleCI is running your tests
Details
ci/circleci: ruby-head-spec Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
Neodelf added a commit to Neodelf/rubocop that referenced this pull request Apr 28, 2020
When the config file path is same as the default config file,
use `ConfigLoader.default_configuration` instead of create a new config.

Because some plugins add their default config values to
`ConfigLoader.default_configuration`. So the Cops of the plugins expect
that default config values exists.

Fix rubocop-hq/rubocop-rails#127

Co-authored-by: Bozhidar Batsov <bozhidar@batsov.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.