[Fix #7564] Drop dependency on jaro_winkler gem #7673
Conversation
|
Hmm … will look into the JRuby failures later. |
buehmann
force-pushed
the
did_you_mean
branch
from
754d3bb
to
2c3833e
Compare
Ruby 2.3 and later ship with the did_you_mean gem, which includes a reusable spell checker based on a JaroWinkler implementation.
buehmann
force-pushed
the
did_you_mean
branch
from
2c3833e
to
db17e00
Compare
|
This was a nice idea, but it is too difficult to make this work across all Ruby versions. To be revisited once RuboCop drops support for Ruby 2.3. |
Having wasted another hour of my life trying to install rubocop in a container and banging my head against the jaro dependency, I would say that if a nice idea is the difference between being able to install rubocop and not, then it's not just a nice idea anymore. If it's that difficult, please focus on dropping the ruby 2.3 support. This evening would be nice, so I can finish this project. |
|
I’m aware of this issue and plan to judgement and drop support for Ruby 2.3 in the near future. But now is not the time. |
### Summary This PR drops support for Ruby 2.3. It is discussed in rubocop#6945. And this suggestion would mean that RuboCop 1.0 (and pre-release) requires Ruby 2.4 or higher. The following is a plan after this PR. There was a build error report for a dependent jaro_winkler gem. rubocop#5989, rubocop#6754, rubocop#7447, and rubocop#7564. And rubocop#7673 was trying to solve it. After dropping Ruby 2.3, replace jaro_winkler with did_you_mean. did_you_mean is written in Ruby, so the build error due to native extensions no longer occur. That change opens as anther PR. ### Other Information The latest did_you_mean (1.4.0) supports Ruby 2.5 or higher, so it needs to be confirmed old versions it works with Ruby 2.4.
### Summary This PR drops support for Ruby 2.3. It is discussed in #6945. And this suggestion would mean that RuboCop 1.0 (and pre-release) requires Ruby 2.4 or higher. The following is a plan after this PR. There was a build error report for a dependent jaro_winkler gem. #5989, #6754, #7447, and #7564. And #7673 was trying to solve it. After dropping Ruby 2.3, replace jaro_winkler with did_you_mean. did_you_mean is written in Ruby, so the build error due to native extensions no longer occur. That change opens as anther PR. ### Other Information The latest did_you_mean (1.4.0) supports Ruby 2.5 or higher, so it needs to be confirmed old versions it works with Ruby 2.4.
Ruby 2.3 and later ship with the
did_you_meangem, which includes aJaroWinkler implementation.
So there is no need to depend on the
jaro_winklergem that people havehad trouble installing lately.
Fixes #7564 and fixes #7447.