Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.3 #7869

Merged
merged 1 commit into from Apr 12, 2020
Merged

Conversation

@koic
Copy link
Member

koic commented Apr 12, 2020

Summary

This PR drops support for Ruby 2.3.

It is discussed in #6945.
And this suggestion would mean that RuboCop 1.0 (and pre-release) requires Ruby 2.4 or higher.

The following is a plan after this PR.
There was a build error report for a dependent jaro_winkler gem.
#5989, #6754, #7447, and #7564. And #7673 was trying to solve it.

After dropping Ruby 2.3, replace jaro_winkler with did_you_mean.
did_you_mean is written in Ruby, so the build error due to native extensions no longer occur. That change opens as anther PR.

Other Information

The latest did_you_mean (1.4.0) supports Ruby 2.5 or higher, so it needs to be confirmed old versions it works with Ruby 2.4.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
### Summary

This PR drops support for Ruby 2.3.

It is discussed in #6945.
And this suggestion would mean that RuboCop 1.0 (and pre-release)
requires Ruby 2.4 or higher.

The following is a plan after this PR.
There was a build error report for a dependent jaro_winkler gem.
#5989, #6754, #7447, and #7564. And #7673 was trying to solve it.

After dropping Ruby 2.3, replace jaro_winkler with did_you_mean.
did_you_mean is written in Ruby, so the build error due to native
extensions no longer occur. That change opens as anther PR.

### Other Information

The latest did_you_mean (1.4.0) supports Ruby 2.5 or higher,
so it needs to be confirmed old versions it works with Ruby 2.4.
@bbatsov bbatsov merged commit 5873894 into rubocop-hq:master Apr 12, 2020
22 checks passed
22 checks passed
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 12, 2020

Great work! Thanks!

After dropping Ruby 2.3, replace jaro_winkler with did_you_mean.
did_you_mean is written in Ruby, so the build error due to native extensions no longer occur. That change opens as anther PR.

I love the plan!

@koic koic deleted the koic:drop_support_for_ruby_2_3 branch Apr 12, 2020
koic added a commit to koic/rubocop-minitest that referenced this pull request Apr 13, 2020
@koic koic mentioned this pull request Apr 13, 2020
7 of 8 tasks complete
koic added a commit to koic/rubocop-minitest that referenced this pull request Apr 13, 2020
koic added a commit to koic/rubocop-rails that referenced this pull request Apr 13, 2020
koic added a commit to koic/rubocop-performance that referenced this pull request Apr 13, 2020
koic added a commit to koic/rubocop-rails that referenced this pull request Apr 13, 2020
koic added a commit that referenced this pull request Apr 13, 2020
Follow up of #7869.
koic added a commit to koic/rubocop that referenced this pull request Apr 13, 2020
Follow rubocop-hq#7384, rubocop-hq#7857, and rubocop-hq#7869.

This PR fixes the next release version with 0.82 because RuboCop 0.81
has been released. This version (0.82) is based on rubocop-hq#7851.
@koic koic mentioned this pull request Apr 13, 2020
7 of 8 tasks complete
@DirtyF
Copy link

DirtyF commented Apr 13, 2020

Question: what is Rubocop policy against current maintained Ruby versions? Given 2.4 is EOL now, when will Rubocop drop 2.4 support?

@bquorning bquorning mentioned this pull request Apr 27, 2020
4 of 5 tasks complete
Neodelf added a commit to Neodelf/rubocop that referenced this pull request Apr 28, 2020
Neodelf added a commit to Neodelf/rubocop that referenced this pull request Apr 28, 2020
Follow rubocop-hq#7384, rubocop-hq#7857, and rubocop-hq#7869.

This PR fixes the next release version with 0.82 because RuboCop 0.81
has been released. This version (0.82) is based on rubocop-hq#7851.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.