Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable `NewCops` for RuboCop development #7875

Merged

Conversation

@koic
Copy link
Member

koic commented Apr 13, 2020

Pending cops will be enabled by default in RuboCop 1.0.

This PR enables NewCops for RuboCop development. It will be a verification that enables pending cops.

And this PR suppresses the following offense.

% cd path/to/rubocop
% bundle exec rake
(snip)

lib/rubocop/config_loader_resolver.rb:184:7: C:
Style/HashTransformValues: Prefer transform_values over Hash[_.map {...}].
      Hash[config.map { |cop, params| [cop, yield(params)] }]
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1144 files inspected, 1 offense detected

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
Pending cops will be enabled by default in RuboCop 1.0.

This PR enables `NewCops` for RuboCop development. It will be
a verification that enables pending cops.

And this PR suppresses the following offense.

```console
% cd path/to/rubocop
% bundle exec rake
(snip)

lib/rubocop/config_loader_resolver.rb:184:7: C:
Style/HashTransformValues: Prefer transform_values over Hash[_.map {...}].
      Hash[config.map { |cop, params| [cop, yield(params)] }]
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1144 files inspected, 1 offense detected
```
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 13, 2020

Great idea!

@koic
Copy link
Member Author

koic commented Apr 13, 2020

Thank you!

@koic koic merged commit e22c2e2 into rubocop-hq:master Apr 13, 2020
22 checks passed
22 checks passed
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@koic koic deleted the koic:enable_new_cops_for_rubocop_development branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.