Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec refactoring #8069

Merged
merged 4 commits into from May 31, 2020
Merged

Spec refactoring #8069

merged 4 commits into from May 31, 2020

Conversation

@marcandre
Copy link
Contributor

marcandre commented May 30, 2020

This PR adds a new functionality: expect_offense can do some text replacements (see style/redundant_exception_spec.rb)

It refactors slightly other specs. This is a prelude to #7868

@marcandre marcandre self-assigned this May 30, 2020
@marcandre marcandre force-pushed the marcandre:preauto branch from 2d3ef44 to e6de982 May 30, 2020
marcandre added 4 commits May 21, 2020
It tests the same thing as the previous spec; their success is not independent.
See [#8016]
This spec would fail with the modern implementation...
@marcandre marcandre force-pushed the marcandre:preauto branch from e6de982 to 4e0f9b4 May 31, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented May 31, 2020

Great work! Probably we should document the specs API somewhere in the dev docs as well.

@marcandre marcandre merged commit 43e07e0 into rubocop-hq:master May 31, 2020
26 checks passed
26 checks passed
windows 2.4
Details
windows 2.5
Details
windows 2.6
Details
windows 2.7
Details
windows mingw
Details
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
@marcandre marcandre deleted the marcandre:preauto branch May 31, 2020
@eugeneius eugeneius mentioned this pull request Jun 7, 2020
7 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.