Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC in Rubocop todo file generation #8146

Merged
merged 1 commit into from Jun 12, 2020

Conversation

@mauro-oto
Copy link
Contributor

mauro-oto commented Jun 12, 2020

Most of our team is distributed, so this is what the diff for our todo file
usually looks like:

- # on 2020-06-05 11:48:43 +1000 using RuboCop version 0.80.1.
+ # on 2020-06-12 12:23:47 -0300 using RuboCop version 0.80.1.

I think it'd be nice to just use UTC and avoid changing timestamp and timezones
so much depending on who generates the file.

I'm aware we can disable the timestamp generation, but I think it's nice to
have. Should this be a similar on/off config, or do you agree it's a saner
default?

Thank you!

@bbatsov bbatsov requested a review from jonas054 Jun 12, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 12, 2020

The suggested change is fine by me, although I guess it deserves a changelog entry.

@marcandre
Copy link
Contributor

marcandre commented Jun 12, 2020

The suggested change is fine by me, although I guess it deserves a changelog entry.

What's the official criteria for deserving a changelog entry? I thought it was only user-facing changes, which I think might be overly restrictive, but this PR is not user-facing and I'd venture to say that even devs don't need to know; there's nothing that needs to be done differently than before.

@bbatsov
Copy link
Collaborator

bbatsov commented Jun 12, 2020

It's user-facing in a way that next time a person regens the TODO they'll likely get a different TZ. Probably many people won't notice it, but I guess some will. Not a big deal for this PR.

@marcandre
Copy link
Contributor

marcandre commented Jun 12, 2020

It's user-facing in a way that next time a person regens the TODO they'll likely get a different TZ. Probably many people won't notice it, but I guess some will. Not a big deal for this PR.

Indeed, brain fart, sorry.

Most of our team is distributed, so this is what the diff for our todo file
usually looks like:

```
- # on 2020-06-05 11:48:43 +1000 using RuboCop version 0.80.1.
+ # on 2020-06-12 12:23:47 -0300 using RuboCop version 0.80.1.
```
@mauro-oto mauro-oto force-pushed the mauro-oto:use-utc-in-rubocop-todo branch from 15af343 to 25e9489 Jun 12, 2020
@mauro-oto
Copy link
Contributor Author

mauro-oto commented Jun 12, 2020

@bbatsov sure, I wasn't sure if it needed one either, I just created a changelog entry for it, thanks!

@marcandre marcandre merged commit 8b3cd93 into rubocop-hq:master Jun 12, 2020
26 checks passed
26 checks passed
windows 2.4
Details
windows 2.5
Details
windows 2.6
Details
windows 2.7
Details
windows mingw
Details
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
@marcandre
Copy link
Contributor

marcandre commented Jun 12, 2020

Thanks @mauro-oto 👍

@mauro-oto mauro-oto deleted the mauro-oto:use-utc-in-rubocop-todo branch Jun 12, 2020
@mauro-oto mauro-oto restored the mauro-oto:use-utc-in-rubocop-todo branch Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.