Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
That sounds reasonable.
Lint. I'm surprised we've put the other two cops until Style, but I guess that's historical - in the very beginning Style was the only department. :-)
E.g. this should probably go under Lint.
I don't see any reason for me to add a
The result from rubocop:
Upon reflection, I have to agree that the case of
Same idea for
Unless there's objection, I'd remove them.
This commit fixes the following error: > Error: The `Style/MethodMissingSuper` cop has been removed since > it has been superseded by `Lint/MissingSuper`. Please use > `Lint/MissingSuper` instead. cf. rubocop-hq/rubocop#8376
I have a similar problem like @haines my service classes inherit but don't need to call super
I would like to exclude those classes or any that inherit from ApplicationService.
fortunately all my services objects are inside app/services so I added this to rubocop.yml
Lint/MissingSuper: Exclude: - 'app/services/**/*'
* Show less months in the dropdown * A bit less top padding for charts * tests for to_s * Adjust month formatting to Mon-Year * Update standard, apply fixes that can auto apply * Ensure we call super so parent classes can initialize This is required to make the latest version of standard happy See rubocop-hq/ruby-style-guide#809 and rubocop-hq/rubocop#8376 for context * More linting fixes * Bump cache versions Just incase the date formatting change happens to mess w/ our cache keys * Fix the keys to match the new period formatting * Updated overview card chart spacing Co-authored-by: claudiovallejo <firstname.lastname@example.org>