Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Lint/MissingSuper [See #8376] #8480

Merged
merged 1 commit into from Aug 7, 2020
Merged

Conversation

@marcandre
Copy link
Contributor

@marcandre marcandre commented Aug 6, 2020

No description provided.

@marcandre marcandre self-assigned this Aug 6, 2020
@marcandre marcandre force-pushed the marcandre:includedandal branch from 15147b8 to 1bbe1d8 Aug 6, 2020
@ruanltbg
Copy link

@ruanltbg ruanltbg commented Aug 6, 2020

Thank you for the hard/fast work.

@fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Aug 6, 2020

Seems like there are another 3 ones https://ruby-doc.org/core-2.7.1/BasicObject.html#method-i-singleton_method_added
Sorry, forgot about them also.

@marcandre marcandre force-pushed the marcandre:includedandal branch from 1bbe1d8 to d3bad88 Aug 6, 2020
@marcandre
Copy link
Contributor Author

@marcandre marcandre commented Aug 6, 2020

Seems like there are another 3 ones https://ruby-doc.org/core-2.7.1/BasicObject.html#method-i-singleton_method_added

I never realize those existed. I can't think of a reason for their existence either, as def singleton_class.method_added should have the same effect. I added them to the list 👍

@koic
koic approved these changes Aug 7, 2020
Copy link
Member

@koic koic left a comment

Nice improvement 👍

@bbatsov bbatsov merged commit 9d5cbe6 into rubocop-hq:master Aug 7, 2020
26 checks passed
26 checks passed
windows 2.4
Details
windows 2.5
Details
windows 2.6
Details
windows 2.7
Details
windows mingw
Details
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
@bbatsov
Copy link
Collaborator

@bbatsov bbatsov commented Aug 7, 2020

Indeed!

@marcandre marcandre deleted the marcandre:includedandal branch Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.