diff --git a/spec/rubocop/cop/performance/collection_literal_in_loop_spec.rb b/spec/rubocop/cop/performance/collection_literal_in_loop_spec.rb index 92e305de0..effbddea5 100644 --- a/spec/rubocop/cop/performance/collection_literal_in_loop_spec.rb +++ b/spec/rubocop/cop/performance/collection_literal_in_loop_spec.rb @@ -144,9 +144,7 @@ RUBY end - # FIXME: `undefined method `[]' for nil` occurs Prism 0.24.0. It has been resolved in - # the development line. This will be resolved in Prism > 0.24.0 and higher releases. - it 'registers an offense when the method is called with no receiver', broken_on: :prism do + it 'registers an offense when the method is called with no receiver' do expect_offense(<<~RUBY) all? do |e| [1, 2, 3].include?(e) diff --git a/spec/rubocop/cop/performance/redundant_merge_spec.rb b/spec/rubocop/cop/performance/redundant_merge_spec.rb index 32f14db18..0b9236066 100644 --- a/spec/rubocop/cop/performance/redundant_merge_spec.rb +++ b/spec/rubocop/cop/performance/redundant_merge_spec.rb @@ -36,9 +36,7 @@ end end - # FIXME: `undefined method `[]' for nil` occurs Prism 0.24.0. It has been resolved in - # the development line. This will be resolved in Prism > 0.24.0 and higher releases. - context 'when receiver is implicit', broken_on: :prism do + context 'when receiver is implicit' do it "doesn't autocorrect" do new_source = autocorrect_source('merge!(foo: 1, bar: 2)') expect(new_source).to eq('merge!(foo: 1, bar: 2)') diff --git a/spec/rubocop/cop/performance/string_identifier_argument_spec.rb b/spec/rubocop/cop/performance/string_identifier_argument_spec.rb index b8013046f..34ad8894f 100644 --- a/spec/rubocop/cop/performance/string_identifier_argument_spec.rb +++ b/spec/rubocop/cop/performance/string_identifier_argument_spec.rb @@ -27,9 +27,7 @@ RUBY end else - # FIXME: `undefined method `[]' for nil` occurs Prism 0.24.0. It has been resolved in - # the development line. This will be resolved in Prism > 0.24.0 and higher releases. - it "registers an offense when using string argument for `#{method}` method", broken_on: :prism do + it "registers an offense when using string argument for `#{method}` method" do expect_offense(<<~RUBY, method: method) #{method}('do_something') _{method} ^^^^^^^^^^^^^^ Use `:do_something` instead of `'do_something'`. @@ -40,18 +38,14 @@ RUBY end - # FIXME: `undefined method `[]' for nil` occurs Prism 0.24.0. It has been resolved in - # the development line. This will be resolved in Prism > 0.24.0 and higher releases. - it "does not register an offense when using symbol argument for `#{method}` method", broken_on: :prism do + it "does not register an offense when using symbol argument for `#{method}` method" do expect_no_offenses(<<~RUBY) #{method}(:do_something) RUBY end if described_class::INTERPOLATION_IGNORE_METHODS.include?(method) - # FIXME: `undefined method `[]' for nil` occurs Prism 0.24.0. It has been resolved in - # the development line. This will be resolved in Prism > 0.24.0 and higher releases. - it 'does not register an offense when using string interpolation for `#{method}` method', broken_on: :prism do + it 'does not register an offense when using string interpolation for `#{method}` method' do # NOTE: These methods don't support `::` when passing a symbol. const_get('A::B') is valid # but const_get(:'A::B') isn't. Since interpolated arguments may contain any content these # cases are not detected as an offense to prevent false positives. @@ -60,9 +54,7 @@ RUBY end else - # FIXME: `undefined method `[]' for nil` occurs Prism 0.24.0. It has been resolved in - # the development line. This will be resolved in Prism > 0.24.0 and higher releases. - it 'registers an offense when using interpolated string argument', broken_on: :prism do + it 'registers an offense when using interpolated string argument' do expect_offense(<<~RUBY, method: method) #{method}("do_something_\#{var}") _{method} ^^^^^^^^^^^^^^^^^^^^^ Use `:"do_something_\#{var}"` instead of `"do_something_\#{var}"`.