Add new RSpec/FactoryBot/SyntaxMethods cop.
#1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoarnold
force-pushed
the
leoarnold/factorybot/dsl
branch
from
6983d3e
to
0d05ba9
Compare
pirj
approved these changes
Nov 23, 2021
| Description: Use the shorthands from `FactoryBot::Syntax::Methods` in your specs. | ||
| Enabled: pending | ||
| SafeAutoCorrect: false | ||
| VersionAdded: "<<next>>" |
There was a problem hiding this comment.
We didn't use that notion in the past, but it's quite a useful trick.
leoarnold
force-pushed
the
leoarnold/factorybot/dsl
branch
2 times, most recently
from
e9fe6d6
to
16ce074
Compare
`FactoryBot` provides a mixin called [`FactoryBot::Syntax::Methods'](https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#rspec) which allows to replace ```ruby FactoryBot.create(:bar) FactoryBot.build(:bar) FactoryBot.attributes_for(:bar) ``` with ``` create(:bar) build(:bar) attributes_for(:bar) ``` The auto-correction is unsafe as there is no way to tell just from syntax whether a given example group includes the mixin or not.
leoarnold
force-pushed
the
leoarnold/factorybot/dsl
branch
from
16ce074
to
5520d3b
Compare
pirj
reviewed
Nov 24, 2021
Darhazer
approved these changes
Nov 25, 2021
| create_pair | ||
| generate | ||
| generate_list | ||
| null |
There was a problem hiding this comment.
FactoryBot::Syntax::Methods.instance_methods.sort 😉
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FactoryBotprovides a mixin called`FactoryBot::Syntax::Methods'
which allows to replace
with
The auto-correction is unsafe as there is no way to tell just from syntax
whether a given example group includes the mixin or not.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.VersionAddedindefault/config.ymlto the next minor version.If you have modified an existing cop's configuration options:
VersionChangedinconfig/default.ymlto the next major version.