Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"none" option for Style/ModuleFunction #7331

Closed
dduugg opened this issue Sep 3, 2019 · 1 comment
Closed

"none" option for Style/ModuleFunction #7331

dduugg opened this issue Sep 3, 2019 · 1 comment
Labels
feature request stale Issues that haven't been active in a while

Comments

@dduugg
Copy link
Contributor

dduugg commented Sep 3, 2019

Is your feature request related to a problem? Please describe.

We have found both extend self and module_function to be problematic for various reasons:

Describe the solution you'd like

Style/ModuleFunction supports two styles, module_function (default) and extend_self. I would like an additional style, which prohibits both, i would suggest calling this none.

Describe alternatives you've considered

We could write a custom cop instead, but it seems more natural to fold it into Style/ModuleFunction.

Additional context

weh added a commit to weh/rubocop that referenced this issue Oct 21, 2019
weh added a commit to weh/rubocop that referenced this issue Oct 23, 2019
@stale
Copy link

stale bot commented Mar 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

@stale stale bot added the stale Issues that haven't been active in a while label Mar 7, 2020
ty-porter pushed a commit to ty-porter/rubocop that referenced this issue Mar 21, 2020
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request stale Issues that haven't been active in a while
Projects
None yet
Development

No branches or pull requests

2 participants