Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'with_fixed_indentation' flag to the Layout/ArrayAlignment cop #7654

Closed
nikitasakau opened this issue Jan 16, 2020 · 0 comments
Closed

Comments

@nikitasakau
Copy link
Contributor

nikitasakau commented Jan 16, 2020

Is your feature request related to a problem? Please describe.

We in our company decided to use Layout/ArgumentAlignment and Layout/ParameterAlignment with with_fixed_indentation. Also we would like to use this flag for Layout/ArrayAlignment too, but this cop doesn't support with_fixed_indentation.

Describe the solution you'd like

I think it would be cool to add with_fixed_indentation flag for Layout/ArrayAlignment as for Layout/ArgumentAlignment and Layout/ParameterAlignment.

Describe alternatives you've considered

I don't see any alternatives

Additional context

We would like to write arrays this way:

array = [1, 2, 3,
  4, 5, 6]
nikitasakau added a commit to nikitasakau/rubocop that referenced this issue Jan 17, 2020
nikitasakau added a commit to nikitasakau/rubocop that referenced this issue Jan 17, 2020
nikitasakau added a commit to nikitasakau/rubocop that referenced this issue Jan 17, 2020
…gnment

Fixes rubocop#7654.

Added support for with_fixed_indentation for Layout/ArrayAlignment as for Layout/ArgumentAlignment and Layout/ParameterAlignment in order to keep the same style for whole code.
nikitasakau added a commit to nikitasakau/rubocop that referenced this issue Jan 27, 2020
…gnment

Fixes rubocop#7654.

Added support for with_fixed_indentation for Layout/ArrayAlignment as for Layout/ArgumentAlignment and Layout/ParameterAlignment in order to keep the same style for whole code.
nikitasakau added a commit to nikitasakau/rubocop that referenced this issue Mar 1, 2020
…gnment

Fixes rubocop#7654.

Added support for with_fixed_indentation for Layout/ArrayAlignment as for Layout/ArgumentAlignment and Layout/ParameterAlignment in order to keep the same style for whole code.
nikitasakau added a commit to nikitasakau/rubocop that referenced this issue Mar 1, 2020
…gnment

Fixes rubocop#7654.

Added support for with_fixed_indentation for Layout/ArrayAlignment as for Layout/ArgumentAlignment and Layout/ParameterAlignment in order to keep the same style for whole code.
@bbatsov bbatsov closed this as completed in 45087a1 Mar 1, 2020
ty-porter pushed a commit to ty-porter/rubocop that referenced this issue Mar 21, 2020
…gnment

Fixes rubocop#7654.

Added support for with_fixed_indentation for Layout/ArrayAlignment as for Layout/ArgumentAlignment and Layout/ParameterAlignment in order to keep the same style for whole code.
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Apr 28, 2020
…gnment

Fixes rubocop#7654.

Added support for with_fixed_indentation for Layout/ArrayAlignment as for Layout/ArgumentAlignment and Layout/ParameterAlignment in order to keep the same style for whole code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant