Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RangeHelp consistent #9760

Open
dvandersluis opened this issue May 2, 2021 · 1 comment
Open

Make RangeHelp consistent #9760

dvandersluis opened this issue May 2, 2021 · 1 comment
Assignees
Milestone

Comments

@dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented May 2, 2021

All methods in RangeHelp that take a range do so with a positional argument, other than range_with_surrounding_space which uses a kwarg. For consistency, range_with_surrounding_space should also use a positional argument.

Changing the signature of this method will impact other RuboCop extensions which will have to be updated, so 2.0 may be a good time to do this.

@pirj
Copy link
Member

@pirj pirj commented Aug 7, 2022

RangeHelp is now pretty consistent. We may eventually want to deprecate the old kwarg, but it's not for 2.0.
Should we keep this to remember of would willingness to deprecate kwarg, or close this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants