Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-gen-config's auto-correction comments #10414

Merged
merged 1 commit into from Feb 22, 2022

Conversation

maxjacobson
Copy link
Contributor

@maxjacobson maxjacobson commented Feb 13, 2022

This is a follow-up to #10384, following a suggestion from bbatsov in the code review.

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@maxjacobson maxjacobson force-pushed the update-auto-correct-message-again branch from 56333e6 to 1e6d825 Compare Feb 13, 2022
@maxjacobson maxjacobson marked this pull request as ready for review Feb 13, 2022
@maxjacobson maxjacobson force-pushed the update-auto-correct-message-again branch from 1e6d825 to 309bf91 Compare Feb 13, 2022
This is a follow-up to 2ca25cd,
following a suggestion from bbatsov in the code review.
@maxjacobson maxjacobson force-pushed the update-auto-correct-message-again branch from 309bf91 to 7143006 Compare Feb 13, 2022
Copy link
Collaborator

@jonas054 jonas054 left a comment

Very nice.

@koic koic merged commit 924b939 into rubocop:master Feb 22, 2022
34 checks passed
@koic
Copy link
Member

koic commented Feb 22, 2022

Thanks!

@maxjacobson maxjacobson deleted the update-auto-correct-message-again branch Feb 22, 2022
ryz310 added a commit to ryz310/rubocop_challenger that referenced this issue Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants