Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10410] Improve help string for --fail-level CLI option #10426

Merged
merged 1 commit into from Feb 20, 2022

Conversation

tejasbubane
Copy link
Contributor

Closes #10410


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

'[C] convention',
'[W] warning',
'[E] error',
'[F] fatal'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already allow both words and abbreviations so no further code changes required.

%w[autocorrect A].each do |severity|
expect { options.parse(['--fail-level', severity]) }
.not_to raise_error
end

@bbatsov bbatsov merged commit fee162c into rubocop:master Feb 20, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 20, 2022

Thanks!

@tejasbubane tejasbubane deleted the fix-10410 branch February 21, 2022 11:43
koic added a commit that referenced this pull request Feb 24, 2022
Follow up #10426.

Indent as with `--format` help text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document --fail-level letter meaning
2 participants