Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate what MFA means in Gemspec/RequireMFA doc #10445

Merged
merged 1 commit into from Mar 7, 2022

Conversation

cbliard
Copy link
Contributor

@cbliard cbliard commented Mar 7, 2022

I got the error, and did not remember what MFA meant. The doc did not help, hence this pull request to add the acronym meaning.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented Mar 7, 2022

docs/modules/ROOT/pages/cops_gemspec.adoc is a generated document. Can you update the original doc https://github.com/rubocop/rubocop/blob/v1.25.1/lib/rubocop/cop/gemspec/require_mfa.rb#L8 instead?

@cbliard
Copy link
Contributor Author

cbliard commented Mar 7, 2022

Sure, sorry, I only followed the "Edit this page" link from the docs.

@cbliard
Copy link
Contributor Author

cbliard commented Mar 7, 2022

It should be better like this now.

@koic koic merged commit c59c090 into rubocop:master Mar 7, 2022
34 checks passed
@koic
Copy link
Member

koic commented Mar 7, 2022

Thanks!

@cbliard cbliard deleted the patch-2 branch Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants