Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Style/SelectByRegexp aware of ENV const #10457

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 18, 2022

Follow up #10155 (comment).

This PR makes Style/SelectByRegexp aware of ENV const.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow up rubocop#10155 (comment).

This PR makes `Style/SelectByRegexp` aware of `ENV` const.
@koic koic merged commit 3112ce7 into rubocop:master Mar 21, 2022
34 checks passed
@koic koic deleted the make_style_select_by_regexp_aware_of_env_const branch Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant