Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto-correction for Lint/DuplicateRequire #10544

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 16, 2022

This PR supports auto-correction for Lint/DuplicateRequire.
The auto-correction is unsafe because it may break the dependency order of require.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the support_autocorrect_for_lint_duplicate_require branch from 9954b6d to dc7be18 Compare Apr 16, 2022
This PR supports auto-correction for `Lint/DuplicateRequire`.
The auto-correction is unsafe because it may break the dependency order of `require`.
@koic koic force-pushed the support_autocorrect_for_lint_duplicate_require branch from dc7be18 to a8089c6 Compare Apr 16, 2022
@bbatsov bbatsov merged commit 6193277 into rubocop:master Apr 17, 2022
34 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 17, 2022

Thanks!

@koic koic deleted the support_autocorrect_for_lint_duplicate_require branch Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants