Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10563] Fix Style/BlockDelimiters unexpectedly deletes block #10564

Conversation

nobuyo
Copy link
Contributor

@nobuyo nobuyo commented Apr 22, 2022

...on moving comment if methods with block are chained.

Fixes #10563.

This PR fixes Style/BlockDelimiters not correctly looking for the end of method chain with block. (The test is passing, but I'm worry about it's not destroying the other cases.)


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…block on moving comment if methods with block are chained
@koic koic merged commit a331f43 into rubocop:master Apr 23, 2022
10 checks passed
@koic
Copy link
Member

koic commented Apr 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants