Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10573] Fix a false positive for Layout/SpaceBeforeBrackets #10575

Conversation

nobuyo
Copy link
Contributor

@nobuyo nobuyo commented Apr 23, 2022

…when using desugared Hash#[] method.

Fixes #10573.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@nobuyo nobuyo marked this pull request as draft Apr 23, 2022
@nobuyo nobuyo force-pushed the fix-false-positive-for-layout-space-before-brackets-if-called-desugared-hash-brackets branch from 5755e38 to 1d8f388 Compare Apr 23, 2022
@nobuyo nobuyo force-pushed the fix-false-positive-for-layout-space-before-brackets-if-called-desugared-hash-brackets branch from 1bb713f to e3d4b08 Compare Apr 23, 2022
@nobuyo nobuyo marked this pull request as ready for review Apr 23, 2022
…ets` when there is a dot before bracket

Update lib/rubocop/cop/layout/space_before_brackets.rb

Co-authored-by: Koichi ITO <koic.ito@gmail.com>

Update lib/rubocop/cop/layout/space_before_brackets.rb

Co-authored-by: Koichi ITO <koic.ito@gmail.com>
@nobuyo nobuyo force-pushed the fix-false-positive-for-layout-space-before-brackets-if-called-desugared-hash-brackets branch from 3a394b5 to 490cb62 Compare Apr 24, 2022
@koic koic merged commit 135bddb into rubocop:master Apr 24, 2022
10 checks passed
@koic
Copy link
Member

koic commented Apr 24, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants