Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #10607] Fix autocorrect for Style/RedundantCondition with parenthesized method call #10609

Conversation

nobuyo
Copy link
Contributor

@nobuyo nobuyo commented May 7, 2022

Fixes #10607.

Sorry that was my bad, the cop now supports parenthesized method calls.

if foo
  some_method(foo)
else
  some_method('bar')
end
# => some_method(foo || 'bar')

foo ? some_method(foo) : some_method('bar')
# => some_method(foo || 'bar')

And fixed highlight range for ternary expression when expression contains method call.

# before
test.rb:4:5: C: [Correctable] Style/RedundantCondition: Use double pipes || instead.
foo ? some_method(foo) : some_method('bar')
    ^^^^^^^^^^^^^^^^^^^^

# after
test.rb:4:1: C: [Correctable] Style/RedundantCondition: Use double pipes || instead.
foo ? some_method(foo) : some_method('bar')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…en there are parenthesized method calls in each branch
@koic koic merged commit 5912850 into rubocop:master May 8, 2022
30 checks passed
@koic
Copy link
Member

@koic koic commented May 8, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants