Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Lint/UselessElseWithoutRescue cop #10697

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 7, 2022

This reverts commit 6d0b336 and tweaked.

Follow up #10577 (comment).

RuboCop 1.29.1 and higher can analyze Ruby 2.5 code again, so it can restore the cop.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This reverts commit 6d0b336 and tweaked.

Follow up rubocop#10577 (comment).

RuboCop 1.29.1 and higher can analyze Ruby 2.5 code again, so it can restore the cop.
@koic koic mentioned this pull request Jun 7, 2022
8 tasks
@bbatsov bbatsov merged commit c258452 into rubocop:master Jun 7, 2022
30 checks passed
@bbatsov
Copy link
Collaborator

@bbatsov bbatsov commented Jun 7, 2022

Thanks!

@koic koic deleted the restore_lint_useless_else_without_rescue_cop branch Jun 7, 2022
bquorning added a commit that referenced this issue Jun 16, 2022
It looks like we forgot to run `rake update_cops_documentation` in the
pull request #10697. I don't know how CI didn't catch this.
@bquorning bquorning mentioned this pull request Jun 16, 2022
8 tasks
@pirj pirj mentioned this pull request Jul 11, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants