From 5dc98e10710db51e62c4fe536e03dbbcefe40017 Mon Sep 17 00:00:00 2001 From: Phil Pirozhkov Date: Thu, 16 May 2024 20:07:32 +0300 Subject: [PATCH 1/4] Also suggest rubocop-rspec for those using rspec-rails rubocop-rspec_rails provides rspec-rails specific cops, but generic rspec cops still apply, as rspec-rails depends on rspec (core, expectations and mocks) --- config/default.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/default.yml b/config/default.yml index d777942a88fa..84edc2864dad 100644 --- a/config/default.yml +++ b/config/default.yml @@ -156,7 +156,7 @@ AllCops: # included. SuggestExtensions: rubocop-rails: [rails] - rubocop-rspec: [rspec] + rubocop-rspec: [rspec, rspec-rails] rubocop-minitest: [minitest] rubocop-sequel: [sequel] rubocop-rake: [rake] From 92b84f8a1f8332bbd9418ae51cd959e63e006483 Mon Sep 17 00:00:00 2001 From: Phil Pirozhkov Date: Thu, 16 May 2024 20:22:08 +0300 Subject: [PATCH 2/4] Add change log entry --- .../change_add_back_rubocop_rspec_to_suggested_extensions.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md diff --git a/changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md b/changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md new file mode 100644 index 000000000000..53ab10596ef0 --- /dev/null +++ b/changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md @@ -0,0 +1 @@ +* [#12908](https://github.com/rubocop/rubocop/pull/12908): Add rubocop-rspec back to suggested extensions when rspec-rails is in use. ([@pirj][]) From 093f38103eb3840c9b724fe83be1ba99246281ce Mon Sep 17 00:00:00 2001 From: Phil Pirozhkov Date: Thu, 16 May 2024 20:25:40 +0300 Subject: [PATCH 3/4] Add a changelog entry --- .../change_add_back_rubocop_rspec_to_suggested_extensions.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md diff --git a/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md b/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md new file mode 100644 index 000000000000..53ab10596ef0 --- /dev/null +++ b/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md @@ -0,0 +1 @@ +* [#12908](https://github.com/rubocop/rubocop/pull/12908): Add rubocop-rspec back to suggested extensions when rspec-rails is in use. ([@pirj][]) From 3dd0e3a65f717124ad5449717b22dc171173d084 Mon Sep 17 00:00:00 2001 From: Phil Pirozhkov Date: Thu, 16 May 2024 20:27:47 +0300 Subject: [PATCH 4/4] Delete changelog from a wrong path --- .../change_add_back_rubocop_rspec_to_suggested_extensions.md | 1 - 1 file changed, 1 deletion(-) delete mode 100644 changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md diff --git a/changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md b/changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md deleted file mode 100644 index 53ab10596ef0..000000000000 --- a/changelog/changelog/change_add_back_rubocop_rspec_to_suggested_extensions.md +++ /dev/null @@ -1 +0,0 @@ -* [#12908](https://github.com/rubocop/rubocop/pull/12908): Add rubocop-rspec back to suggested extensions when rspec-rails is in use. ([@pirj][])