Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a space before first argument of a method call #4265

Merged

Conversation

cjlarose
Copy link
Contributor

@cjlarose cjlarose commented Apr 12, 2017

The Ruby parser appears to be completely fine with something like

puts'hello'

The cop Style/SpaceBeforeFirstArg claims to check that "exactly one space is used between a method name and the first argument for method calls without parentheses", but does not account for source code that has zero spaces between the method name and the first argument.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@rchasman
Copy link

🐬

@rchasman
Copy link

^ LGTM

CHANGELOG.md Outdated
@@ -2,6 +2,9 @@

## master (unreleased)

### New features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a section called Changes where we normally put changes to existing cops, although this might even qualify as a bug fix. 🙂

@Drenmi
Copy link
Collaborator

Drenmi commented Apr 12, 2017

Great first contribution! ❤️

@@ -4,6 +4,7 @@

### Bug fixes

* [#4265](https://github.com/bbatsov/rubocop/pull/4265): Require a space before first argument of a method call in `Style/SpaceBeforeFirstArg` cop. ([@cjlarose][])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add yourself to the bottom of the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! Updated the CHANGELOG with a link to myself.

Ruby permits a method name to be followed immediately by a string
literal, with no space between them. This change updates the
SpaceBeforeFirstArg cop to register a violation for source code that
does this.
@cjlarose cjlarose force-pushed the require-space-between-method-name-and-argument branch from 90b62af to b2d627e Compare April 12, 2017 17:03
@bbatsov bbatsov merged commit fde6b20 into rubocop:master Apr 12, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 12, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants