Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .axlsx file by default #5532

Merged
merged 1 commit into from Feb 2, 2018
Merged

Include .axlsx file by default #5532

merged 1 commit into from Feb 2, 2018

Conversation

georf
Copy link
Contributor

@georf georf commented Jan 31, 2018

axlsx_rails gem uses .axlsx extension.
https://github.com/straydogstudio/axlsx_rails

For example:

wb = xlsx_package.workbook
wb.add_worksheet(name: "Buttons") do |sheet|
  @buttons.each do |button|
      sheet.add_row [button.name, button.category, button.price]
  end
end

I've added .axlsx to TargetFinder and default.yml


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Feb 2, 2018

@pocke Can you take a look? I don't remember myself all the places that needed to be changed for new file extensions.

Copy link
Collaborator

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!
This pull request changes the same files as https://github.com/bbatsov/rubocop/pull/4385/files , so it is correct.

@pocke
Copy link
Collaborator

pocke commented Feb 2, 2018

@georf Can you rebase on top of master?

axlsx_rails gem uses `.axlsx` extension.
https://github.com/straydogstudio/axlsx_rails

For example:

```ruby

wb = xlsx_package.workbook
wb.add_worksheet(name: "Buttons") do |sheet|
@buttons.each do |button|
    sheet.add_row [button.name, button.category, button.price]
end
end

```
@georf
Copy link
Contributor Author

georf commented Feb 2, 2018

@pocke Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants