Add comparison style to Style/NilComparison
#6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiav223577
force-pushed
the
feature/add_explicit_comparison_style
branch
from
aba301a
to
a4165e0
Compare
khiav223577
force-pushed
the
feature/add_explicit_comparison_style
branch
from
a4165e0
to
54ab389
Compare
bbatsov
reviewed
Aug 25, 2018
config/default.yml
Outdated
| EnforcedStyle: predicate_method | ||
| SupportedStyles: | ||
| - predicate_method | ||
| - explicit_comparison |
There was a problem hiding this comment.
Think this should be named comparison_method (or operator).
There was a problem hiding this comment.
I see we named this simply predicate and comparison in a similar cop (NumericComparison), so we should probably stick to this for consistency.
bbatsov
reviewed
Aug 25, 2018
| include ConfigurableEnforcedStyle | ||
|
|
||
| PREDICATE_MSG = 'Prefer the use of the `nil?` predicate.'.freeze | ||
| EXPLICIT_MSG = 'Prefer the use of the explicit `==` comparison.'.freeze |
There was a problem hiding this comment.
I'd remove explicit here.
khiav223577
changed the title
explicit_comparison style to Style/NilComparisonexplicit style to Style/NilComparison
khiav223577
changed the title
explicit style to Style/NilComparisoncomparison style to Style/NilComparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add a new style for Style/NilComparison. It allows developers to choose which style they prefer (
nil?or== nil).Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.