Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6880] Fix RuboCop::Options#parse for .rubocop file parsing #7015

Merged
merged 1 commit into from May 3, 2019

Conversation

@hoshinotsuyoshi
Copy link
Contributor

@hoshinotsuyoshi hoshinotsuyoshi commented May 3, 2019

Fixes #6880

  • After this commit, RuboCop parses .rubocop(even if content is like --format progress) correctly.
  • More natural test case of .rubocop file content.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
…sing

* After this commit, RuboCop parses `.rubocop`(even if content is like `--format progress`) correctly.
* More natural test case of `.rubocop` file content.
@koic koic merged commit 2a4f4f0 into rubocop:master May 3, 2019
25 checks passed
Loading
@koic
Copy link
Member

@koic koic commented May 3, 2019

Thanks!

Loading

@hoshinotsuyoshi hoshinotsuyoshi deleted the fix_6880 branch May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants